Skip to content

Add sample for onCallGenkit #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 5, 2025
Merged

Add sample for onCallGenkit #1189

merged 7 commits into from
Feb 5, 2025

Conversation

jhuleatt
Copy link
Collaborator

@jhuleatt jhuleatt commented Jan 31, 2025 •
edited
Loading

There are a lot of snippet tags in here because I want to make sure we can get close to matching all the snippets currently hardcoded into https://github.com/firebase/genkit/blob/main/docs/firebase.md

@jhuleatt jhuleatt requested review from egilmorez and taeold January 31, 2025 17:25
@jhuleatt jhuleatt marked this pull request as ready for review January 31, 2025 18:46
taeold
taeold approved these changes Jan 31, 2025
View reviewed changes
egilmorez
egilmorez reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That IS a lot of tags! But if you have mapped them to the existing snippets, that makes a world of sense.

Though we are inconsistent about it in other samples, it would be great to have basic punctuation in any comments that are displayed in the docs -- mainly periods in this file.

Are you game to do an add-periods scrub, and then if I can find anything else I'll comment specifically? Thanks Jeff!

egilmorez
egilmorez approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Eager to get the snippets generated. :)

@jhuleatt
Copy link
Collaborator Author

jhuleatt commented Feb 5, 2025

That IS a lot of tags! But if you have mapped them to the existing snippets, that makes a world of sense.

Though we are inconsistent about it in other samples, it would be great to have basic punctuation in any comments that are displayed in the docs -- mainly periods in this file.

Are you game to do an add-periods scrub, and then if I can find anything else I'll comment specifically? Thanks Jeff!

I've added punctuation and clarified some comments - going to merge now so you can generate snippets!

@jhuleatt jhuleatt merged commit 8e35cdc into main Feb 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@egilmorez egilmorez egilmorez approved these changes

@taeold taeold taeold approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jhuleatt @egilmorez @taeold